changed E0067 to new error format #35616
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Fixing tidy error |
|
Thanks for the PR! Looks good so far. The next step is to test the label you added. There's a quirk in the test system where it won't test labels until you add at least one. You can read about it in the Extra Credit section of the blog post. |
|
Added test for new format of error E0368 |
|
Looks good! @bors r+ rollup |
|
📌 Commit bd90a16 has been approved by |
… r=jonathandturner changed E0067 to new error format Updated E0067 to new error format. Part of rust-lang#35233 Fixes rust-lang#35502 Passes all the tests when running: `python src/bootstrap/bootstrap.py --step check-cfail --stage 1` **This seems strange, given that the format for E0067 has been changed.** It feels like it should fail some unit tests maybe? Let me know if I'm mistaken. Otherwise I can create a unit test for it. Thanks for letting me help! r? @jonathandturner
… r=jonathandturner changed E0067 to new error format Updated E0067 to new error format. Part of rust-lang#35233 Fixes rust-lang#35502 Passes all the tests when running: `python src/bootstrap/bootstrap.py --step check-cfail --stage 1` **This seems strange, given that the format for E0067 has been changed.** It feels like it should fail some unit tests maybe? Let me know if I'm mistaken. Otherwise I can create a unit test for it. Thanks for letting me help! r? @jonathandturner
… r=jonathandturner changed E0067 to new error format Updated E0067 to new error format. Part of rust-lang#35233 Fixes rust-lang#35502 Passes all the tests when running: `python src/bootstrap/bootstrap.py --step check-cfail --stage 1` **This seems strange, given that the format for E0067 has been changed.** It feels like it should fail some unit tests maybe? Let me know if I'm mistaken. Otherwise I can create a unit test for it. Thanks for letting me help! r? @jonathandturner
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
Updated E0067 to new error format.
Part of #35233
Fixes #35502
Passes all the tests when running:
python src/bootstrap/bootstrap.py --step check-cfail --stage 1This seems strange, given that the format for E0067 has been changed.
It feels like it should fail some unit tests maybe?
Let me know if I'm mistaken. Otherwise I can create a unit test for it.
Thanks for letting me help!
r? @jonathandturner